I’m adapting a test to test that the undo/redo functionality is working correctly, but whilst it works fine with manual testing I’m having trouble getting it to work automatically. ` it('check Analytics block moving ', () => { const diagram: go.Diagram = component.getGoJSDiagramProvider().getGo…

One can only perform undo or redo between transactions – not during a transaction. Has your detectChanges function accidentally made some changes?

I’m not attempting any undo within the transaction. The steps are: Start with blank canvas Start transaction Add block to canvas Check block location Move block Check block location Commit transaction Check canUndo() which is returning false.

How are you updating your “Undo” and “Redo” buttons? I just tried the code that is demonstrated at GoJS Commands -- Northwoods Software , and it worked as expected. Here’s my code: function init() { . . . initialization of myDiagram . . . // enable or disable a particular button functio…

Thanks for that. Based on this I went back to scratch to create as simple a test function as possible for Angular: it('test', () => { //const diagram: go.Diagram = component.getGoJSDiagramProvider().getGoJSDiagram(); const diagram: go.Diagram = new go.Diagram(); diagram.undoManager.isEnabled = true…

Even if I knew what test system you were using and what else was going on in your page, I wouldn’t know anything about it. Here’s the definition of UndoManager.canUndo: UndoManager.prototype.canUndo = function() { if (!this.isEnabled) return false; if (this.transactionLevel > 0) return false; …

Thanks. This helps a lot in knowing what to check. One thing Ive noticed is that there’s a typo in historyIndex in UndoManager with it being defined as hisotryIndex.

Does commitTranaction() have any checks as to whether it adds a transaction to the history? In both cases there is a currentTransaction immediately prior to calling commitTransaction(). With the clean go.Diagram, the transaction is added to the history and we history.count = 1, but in the other cas…

[image] nmfa: sotry I just checked all of our sources, including samples and documentation, and found no instance of the string “sotry”. I suggest that you look at the changes that are recorded in that earlier Transaction, if there are any.

Am I correct is assuming that when a change happens outside of a transaction that will stop the undo/redo working as it will be impossible to keep the model consistent through that point of the history? I ask because in my test, in the case that isn’t working I’m getting a Change not within transac…

Yes, that is what I have been saying since my first reply. You need to figure out why you are removing a Part from the diagram between transactions.

Northwoods Software

Programatic use of undo/redo

GoJS

show post in topic

Home
Categories
Guidelines
Terms of Service
Privacy Policy

Powered by Discourse, best viewed with JavaScript enabled