3.0.8 update issues

GoJS
1

Our legacy code has class extending HTMLInfo:

class DefaultHTMLInfo extends HTMLInfo { ... }

We then have other classes extending DefaultHTMLInfo. When I upgraded to v3, I had to make updates to show, hide, and valueFunction such as:

valueFunction = () => this.textAreaElement.value;

to

get valueFunction() {
    return () => this.textAreaElement.value;
 }

We are using TypeScript and tsc and eslint are both happy with our code. However, in our Jest tests, many are now failing:

const setup = (params) => {
  const diagramController = new DiagramController({ ... });
  const  { nodeDataArray, linkDataArray } = buildData(...);
  diagramController.setDiagramModel(nodeDataArray, linkDataArray);
  return diagramController;
}

My tests are failing within setDiagramModel at this line:

  diagram.model = $(GraphLinksModel, {
    linkDataArray: linkDataArray || [],
    linkFromPortIdProperty: ...,
    linkToPortIdProperty: ...,
    modelData: globalSettings.getSettings(),
    nodeDataArray: nodeDataArray || [],
  });

I am not sure if my changes to the accessors in the child classes are the problem if there is something entirely broken in how I create the Node/Link arrays. Do you have any idea what could cause to break?

2

In general we have been trying to remove uses of GraphObject.make from our samples, even though you can freely mix code styles. You might want to use new go.GraphLinksModel({ . . . }), just in case the “$” in your code isn’t right.

But your code looks fine. So I cannot explain the problem. Can you show us better (i.e. more complete) error messages?

3

The error occurs when I try to find a node that should be there (and I debug it, and it says it is there), but findNodeForKey(5) is not there, even though when I debug it, I can get the node list, index 5, and there’s the node.

    const containedNode = diagramController.diagram.findNodeForKey(5) as Node;
    containedNode.isSelected = true;

The failure is when the test sets isSelected to true, but isSelected is on a null object. But in v2, this object is not null.

4

I also noticed that when I do:

myDiagram.addDiagramListener("InitialLayoutCompleted", () => {
  const containedNode = diagramController.diagram.findNodeForKey(5) as Node;
  containedNode.isSelected = true;
  ...
})

then one isolated test works.

5

using diagram.model = new GraphLinksModel({...}) made no difference, unfortunately. But that is nicer, IMO.

6

Could you please show us the node data object in the model? Maybe it was created with a key that was “5” (a string), but your test is trying to look it up with 5 (a number).

7

Holy smokey - that worked. Thank you, Walter.