Links Disconnecting After Rotate-Undo

rwdial · February 19, 2013, 12:52pm

I have come across an issue when I draw a link from an object:

rotate the object:

then undo, I get this:

Any suggestion as to what might be causing this? Or how I can fix it?

Thanks
Ryan

walter · February 19, 2013, 1:18pm

That’s odd. Can you reproduce the problem in the Draggable Links sample?

rwdial · February 19, 2013, 1:51pm

No I wasn’t able to replicate it in the sample.

Though with further testing I have been able to fix the problem…

if (((Northwoods.GoXam.Model.UndoManager.CompoundEdit)this.Diagram.Model.UndoManager.EditToUndo).Name == “Rotate”)
{
 base.Undo();

 foreach (PipeData data in EditPartsData.Where(x => x is PipeData))
 {
 Link link = this.Diagram.Links.Where(x => x.Data == data).FirstOrDefault();
 if (link.Route.Points != data.Points)
 link.Route.Points = data.Points.ToList();
 }
}

Note - EditPartsData contains the data’s of each of the nodes/links involved in the EditToUndo

walter · February 19, 2013, 1:57pm

That may be a work-around, but it doesn’t explain the behavior in the first place.
What other things are you doing around a transaction or an undo or a redo?

rwdial · February 19, 2013, 3:41pm

This is what our Undo currently looks like:


public override void Undo()
        {
            EditPartsData = new List<object>();<span style="font-size: 12px; line-height: 1.4;">            </span>

            if (this.Diagram.Model.UndoManager.EditToUndo == null) return;
            
            foreach (ModelChangedEventArgs edit in ((Northwoods.GoXam.Model.UndoManager.CompoundEdit)this.Diagram.Model.UndoManager.EditToUndo).Edits)
                EditPartsData.Add(edit.Data);

            if (((Northwoods.GoXam.Model.UndoManager.CompoundEdit)this.Diagram.Model.UndoManager.EditToUndo).Name == "Rotate")
            {
                base.Undo();  

                foreach (PipeData data in EditPartsData.Where(x => x is PipeData))
                {
                    Link link = this.Diagram.Links.Where(x => x.Data == data).FirstOrDefault();

                    if (link.Route.Points != data.Points)
                        <span style="font-size: 12px; line-height: 1.4;">link.Route.Points = data.Points.ToList();</span><span style="font-size: 12px; line-height: 1.4;">                    </span>
                }
            }
            else
                base.Undo();<span style="font-size: 12px; line-height: 1.4;">        </span>
        }

walter · February 19, 2013, 4:25pm

Hmm, that looks like it is entirely for the purpose of implementing the work-around.

Are there are warnings or errors in the Output Window (trace listeners) at any time during the editing process or the undo or the redo?

Have you overridden any other methods?

rwdial · February 19, 2013, 5:01pm

Nothing in the output window… Though one thing that sticks out to me is that after the undo, the link is still going to the position of where the anchor used to be. Is it possible that the route points are being recomputed before the object is rotated back to its previous position?

We have overridden large portions of the base code, in this case I would assume the most relevant would be the Link.Route, but when I switch back to the base Route the problem remains. Any suggestion for other areas to look at?

walter · February 19, 2013, 5:21pm

Do you use a custom PartManager, like the one in the Draggable Link sample, that sets UpdatesRouteDataPoints and overrides UpdateRouteDataPoints, and perhaps does the other overrides too?

rwdial · February 19, 2013, 5:51pm

Yes we do have a custom PartManager. UpdatesRouteDataPoints is true, and we’ve copied the UpdateRouteDataPoints from the sample. We’ve also overridden OnLinkAdded, OnLinkRemoving, OnNodeAdded, and OnNodeRemoving.