Upgrade 1.8.34 to 2.0.3

GoJS
1

Hello,
I upgraded my Typescript application from a 1.8.34 to 2.03 and now I get following errors at compilation :

ERROR in node_modules/gojs/release/go.d.ts(14360,27): error TS1005: ')' expected.

node_modules/gojs/release/go.d.ts(14360,45): error TS1005: ‘,’ expected.
node_modules/gojs/release/go.d.ts(14360,68): error TS1005: ‘,’ expected.
node_modules/gojs/release/go.d.ts(14361,16): error TS1005: ‘,’ expected.
node_modules/gojs/release/go.d.ts(14361,38): error TS1005: ‘,’ expected.
node_modules/gojs/release/go.d.ts(14362,43): error TS1005: ‘,’ expected.
node_modules/gojs/release/go.d.ts(14363,5): error TS1138: Parameter declaration expected.
node_modules/gojs/release/go.d.ts(14363,7): error TS1128: Declaration or statement expected.
node_modules/gojs/release/go.d.ts(14363,11): error TS1128: Declaration or statement expected.
node_modules/gojs/release/go.d.ts(14363,12): error TS1128: Declaration or statement expected.
node_modules/gojs/release/go.d.ts(14363,14): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14363,34): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14363,71): error TS1005: ‘;’ expected.
node_modules/gojs/release/go.d.ts(14363,73): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14363,93): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14363,166): error TS1005: ‘;’ expected.
node_modules/gojs/release/go.d.ts(14363,168): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14363,188): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14363,233): error TS1005: ‘;’ expected.
node_modules/gojs/release/go.d.ts(14363,235): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14363,255): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14363,292): error TS1005: ‘;’ expected.
node_modules/gojs/release/go.d.ts(14363,294): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14363,314): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14363,354): error TS1005: ‘;’ expected.
node_modules/gojs/release/go.d.ts(14363,356): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14363,412): error TS1005: ‘(’ expected.
node_modules/gojs/release/go.d.ts(14364,11): error TS1005: ‘]’ expected.
node_modules/gojs/release/go.d.ts(14364,19): error TS1005: ‘,’ expected.
node_modules/gojs/release/go.d.ts(14364,20): error TS1136: Property assignment expected.
node_modules/gojs/release/go.d.ts(14364,25): error TS1005: ‘:’ expected.
node_modules/gojs/release/go.d.ts(14365,27): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14366,38): error TS1005: ‘,’ expected.
node_modules/gojs/release/go.d.ts(14367,43): error TS1005: ‘,’ expected.
node_modules/gojs/release/go.d.ts(14368,34): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14368,71): error TS1005: ‘;’ expected.
node_modules/gojs/release/go.d.ts(14368,73): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14368,93): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14368,166): error TS1005: ‘;’ expected.
node_modules/gojs/release/go.d.ts(14368,168): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14368,188): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14368,233): error TS1005: ‘;’ expected.
node_modules/gojs/release/go.d.ts(14368,235): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14368,255): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14368,292): error TS1005: ‘;’ expected.
node_modules/gojs/release/go.d.ts(14368,294): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14368,314): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14368,354): error TS1005: ‘;’ expected.
node_modules/gojs/release/go.d.ts(14368,356): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14368,369): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14368,370): error TS1128: Declaration or statement expected.
node_modules/gojs/release/go.d.ts(14368,388): error TS1005: ‘(’ expected.
node_modules/gojs/release/go.d.ts(14387,5): error TS1128: Declaration or statement expected.
node_modules/gojs/release/go.d.ts(14387,30): error TS1005: ‘,’ expected.
node_modules/gojs/release/go.d.ts(14387,44): error TS1005: ‘,’ expected.
node_modules/gojs/release/go.d.ts(14387,78): error TS1005: ‘;’ expected.
node_modules/gojs/release/go.d.ts(14387,84): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14402,5): error TS1128: Declaration or statement expected.
node_modules/gojs/release/go.d.ts(14402,36): error TS1005: ‘,’ expected.
node_modules/gojs/release/go.d.ts(14402,48): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14402,57): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14402,69): error TS1109: Expression expected.
node_modules/gojs/release/go.d.ts(14402,100): error TS1005: ‘;’ expected.
node_modules/gojs/release/go.d.ts(14403,1): error TS1128: Declaration or statement expected.

I compile the project with ES5 as target and I import GoJS like that : import * as go from “gojs”;

Do you have any idea of want is going on ?

2

What version of TypeScript are you using? The go.d.ts file requires v2.8.

3

Ok thanks. I was in v2.7.x and I passed in v2.9.2

But now I have the following error on “go.TreeLayout” : TS2345: Argument of type ‘typeof TreeLayout’ is not assignable to parameter of type ‘string’.

this.diagram.layout = $(go.TreeLayout,
{angle: 90, layerSpacing: 35});

4

Could you please verify that the value of “$” is actually the value of go.GraphObject.make?

Does this work:
this.diagram.layout = $<go.TreeLayout>(go.TreeLayout, { angle: . . .})

I don’t know why it didn’t figure out the correct typing for the call to GraphObject.make.

5

Yes, it is. (let $ = go.GraphObject.make;)

I try to type like your example but i have the following error :
TS2344: Type ‘TreeLayout’ does not satisfy the constraint ‘GraphObject’. Property ‘getDocumentPoint’ is missing in type ‘TreeLayout’.

I don’t know if it’s related but in the “go.d.ts” i have an error on the second make function (l14353). I have the following error on static make<CT extends…
TS7010: ‘make’, which lacks return-type annotation, implicitly has an ‘any’ return type.

6

What? It sounds as if your go.d.ts file is corrupted. When I look at https://raw.githubusercontent.com/NorthwoodsSoftware/GoJS/master/release/go.d.ts, the declaration looks like it is returning the correct type:

    static make<CT extends ConstructorType<CT>>(cls: CT, ...initializers: Array<string | (Partial<InstanceType<CT>> & {
        [p: string]: any;
    } & (InstanceType<CT> extends Diagram ? DiagramEventsInterface & {
        Changed?: ChangedEventHandler;
        ModelChanged?: ChangedEventHandler;
    } : {})) | (InstanceType<CT> extends GraphObject ? Binding : never) | (InstanceType<CT> extends Panel ? (GraphObject | RowColumnDefinition | PanelLayout) : never) | (InstanceType<CT> extends RowColumnDefinition ? Binding : never) | (InstanceType<CT> extends Geometry ? PathFigure : never) | (InstanceType<CT> extends PathFigure ? PathSegment : never) | EnumValue | Array<string | (Partial<InstanceType<CT>> & {
        [p: string]: any;
    } & (InstanceType<CT> extends Diagram ? DiagramEventsInterface & {
        Changed?: ChangedEventHandler;
        ModelChanged?: ChangedEventHandler;
    } : {})) | (InstanceType<CT> extends GraphObject ? Binding : never) | (InstanceType<CT> extends Panel ? (GraphObject | RowColumnDefinition | PanelLayout) : never) | (InstanceType<CT> extends RowColumnDefinition ? Binding : never) | (InstanceType<CT> extends Geometry ? PathFigure : never) | (InstanceType<CT> extends PathFigure ? PathSegment : never) | EnumValue>>): InstanceType<CT>;
1 Like
7

I I just had my webstorm in 2018.3.4. and I do not have the messages anymore.

Thanks

8

3 posts were split to a new topic: Upgrading Angular project